Skip to content

🐙 octavia-cli: package and install script #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 9, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Mar 3, 2022

What

This PRs aims at improving the packaging of the CLI and easing its installation (#10708)

How

Fixes:

Addition:

🚨 User Impact 🚨

octavia can be installed

@alafanechere alafanechere temporarily deployed to more-secrets March 3, 2022 10:56 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 3, 2022 10:56 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 3, 2022 10:59 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 3, 2022 11:00 Inactive
@marcosmarxm
Copy link
Member

@alafanechere minor one can you update the doc tests?

6. Run the test suite: `pytest --cov=octavia_cli unit_tests`

to run with only tests folder? :D

@alafanechere alafanechere temporarily deployed to more-secrets March 4, 2022 11:12 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 4, 2022 11:12 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 4, 2022 18:11 Inactive
@alafanechere alafanechere changed the title 🐙 octavia-cli: docker packaging 🐙 octavia-cli: packaging and install script Mar 4, 2022
@alafanechere alafanechere temporarily deployed to more-secrets March 4, 2022 18:13 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 4, 2022 18:13 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 16:40 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 16:40 Inactive
@alafanechere alafanechere marked this pull request as ready for review March 5, 2022 16:46
@alafanechere alafanechere requested a review from lmossman March 5, 2022 16:46
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 18:31 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 18:31 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 18:34 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 18:34 Inactive
@alafanechere alafanechere marked this pull request as draft March 5, 2022 18:36
@alafanechere alafanechere marked this pull request as ready for review March 5, 2022 19:13
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 19:14 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 19:14 Inactive
@alafanechere alafanechere added this to the octavia-cli-alpha milestone Mar 5, 2022
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 23:01 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 5, 2022 23:01 Inactive
@alafanechere alafanechere linked an issue Mar 7, 2022 that may be closed by this pull request
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment about the path to local instance when using docker.
Overall the script is working a

check_docker_is_running
detect_profile
set -u
update_or_install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
image

@alafanechere alafanechere temporarily deployed to more-secrets March 8, 2022 20:35 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 8, 2022 20:35 Inactive
@alafanechere alafanechere requested a review from marcosmarxm March 9, 2022 07:33
@alafanechere alafanechere changed the title 🐙 octavia-cli: packaging and install script 🐙 octavia-cli: package and install script Mar 9, 2022
@alafanechere alafanechere temporarily deployed to more-secrets March 9, 2022 14:18 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 9, 2022 14:18 Inactive
echo 'alias octavia="docker run airbyte/octavia-cli:dev"' >> ~/.zshrc
source ~/.zshrc
octavia
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" -e AIRBYTE_WORKSPACE_ID="${AIRBYTE_WORKSPACE_ID}" airbyte/octavia-cli:dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" -e AIRBYTE_WORKSPACE_ID="${AIRBYTE_WORKSPACE_ID}" airbyte/octavia-cli:dev
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" airbyte/octavia-cli:dev

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alafanechere alafanechere merged commit ad20f00 into master Mar 9, 2022
@alafanechere alafanechere deleted the augustin/octavia-cli/docker-packaging branch March 9, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐙 octavia-cli: package into a docker image
2 participants