-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🐙 octavia-cli: package and install script #10823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alafanechere minor one can you update the doc tests?
to run with only tests folder? :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment about the path to local instance when using docker.
Overall the script is working a
check_docker_is_running | ||
detect_profile | ||
set -u | ||
update_or_install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo 'alias octavia="docker run airbyte/octavia-cli:dev"' >> ~/.zshrc | ||
source ~/.zshrc | ||
octavia | ||
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" -e AIRBYTE_WORKSPACE_ID="${AIRBYTE_WORKSPACE_ID}" airbyte/octavia-cli:dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" -e AIRBYTE_WORKSPACE_ID="${AIRBYTE_WORKSPACE_ID}" airbyte/octavia-cli:dev | |
docker run --rm -v ${PWD}:/home/octavia-project --network host -e AIRBYTE_URL="${AIRBYTE_URL}" airbyte/octavia-cli:dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
This PRs aims at improving the packaging of the CLI and easing its installation (#10708)
How
Fixes:
pyyaml
dependency: octavia-cli/setup.pytemplates
directory from./octavia_cli
to./octavia_cli/generate/
+ octavia-cli/octavia_cli/generate/renderer.pyAddition:
octavia
alias to user's shell profile.octavia
is an alias to adocker run
command🚨 User Impact 🚨
octavia
can be installed