-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Handle negative credit in UI #10814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle negative credit in UI #10814
Conversation
I've been thinking about this PR a bit, and think we should rather try to avoid handling this via Features. Our feature service is atm designed to be "static" features of a specific deployment, thus also contributing towards the issue I described in my above comment. We also should try to decouple the FeatureService from the ConfigService (first) imho (see #10974). I think for now it would be better if we simply not use Features for this change, but just have regular utility methods that we can call on the workspace (or a custom hook for it), that will provide us the given information. |
@timroes per our discussion during the sync, we are going to leave it in Added few unit tests that make sure there are no cyclic dependencies. Also now it uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. Disables all described places. LGTM
What
Limit actions for users with negative (
negative_max_threshold
,negative_beyond_grace_period
) credit statusEnabled
toggle on Connection Status pageSync now
button on Connection Status pageLaunch
button andSync
toggle on Connections pageNew connection
button on Connections pageCreate connection
dropdown on Source/Destination pagesCloses #10632