Skip to content

🎉 New Destination: AWS Datalake #10760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 4, 2022
Merged

🎉 New Destination: AWS Datalake #10760

merged 11 commits into from
Apr 4, 2022

Conversation

kattos-aws
Copy link
Contributor

What

This destination connector allows for ingestion of data into an AWS data lake.

How

This destination connector takes advantage of the new governed tables features to better integrate the data into the larger AWS data ecosystem (ex: Glue, Athena, Redshift, ...)

Recommended reading order

  1. docs/integrations/aws-datalake.md
  2. airbyte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/destination.py
  3. airbyte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/airbyte_helper.py
  4. airbyte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/aws_helpers.py
  5. ... the rest :)

🚨 User Impact 🚨

None

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 1, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2022

CLA assistant check
All committers have signed the CLA.

@marcosmarxm
Copy link
Member

Thanks @kattos-aws can you sign the CLA and share the test output from the connector? There is a implementation in python and some files in Java, can you explain the implementation you made?

@kattos-aws
Copy link
Contributor Author

Thanks @kattos-aws can you sign the CLA and share the test output from the connector? There is a implementation in python and some files in Java, can you explain the implementation you made?

I did sign the CLA:
Signed CLA
Not sure what is going on here, any idea?

Here is the log for the Destination Acceptance Test suite:
airbyte-integration-tests.log.gz

The connector itself is in Python, but as there were no Destination Acceptance Tests in Python, I had to write a bit of Java code to be able to run the DAT.

Hope that makes sense, feel free to reach out if you need more info. Also available for a call if need be!

@marcosmarxm
Copy link
Member

@kattos-aws can you share the output from the acceptance tests?

@kattos-aws
Copy link
Contributor Author

@marcosmarxm Sorry I realize my comment was really not clear. The logs I attached in my previous comment are actually the output of the acceptance tests. I did not implement specific integration tests.

I ran the tests as indicated in the generated README.md:

To run acceptance and custom integration tests:

```bash
  ./gradlew :airbyte-integrations:connectors:destination-aws-datalake:integrationTest
```

If you search for the string AwsDatalakeDestinationAcceptanceTest in the logs, you will find the section for this connector.

I hope that clears that out! If not, feel free to reach out.

Thanks!

@marcosmarxm marcosmarxm changed the title Implementation of a destination connector for AWS Datalake New Source: AWS Datalake Mar 14, 2022
@marcosmarxm marcosmarxm changed the title New Source: AWS Datalake New Destination: AWS Datalake Mar 14, 2022
@marcosmarxm marcosmarxm changed the title New Destination: AWS Datalake 🎉 New Destination: AWS Datalake Mar 14, 2022
@sherifnada sherifnada requested a review from alafanechere March 29, 2022 03:45
@sherifnada
Copy link
Contributor

@alafanechere @marcosmarxm would either of you have bandwidth to review this PR from Stephane, our friend at AWS?

@sherifnada sherifnada requested a review from marcosmarxm March 29, 2022 03:46
@kattos-aws kattos-aws requested a review from a team as a code owner March 29, 2022 22:06
@github-actions github-actions bot added area/api Related to the api area/frontend area/platform issues related to the platform area/protocol area/scheduler area/server area/worker Related to worker CDK Connector Development Kit kubernetes normalization labels Mar 29, 2022
@github-actions github-actions bot removed CDK Connector Development Kit area/server kubernetes area/frontend area/platform issues related to the platform area/protocol area/scheduler normalization area/worker Related to worker area/api Related to the api labels Mar 29, 2022
@marcosmarxm marcosmarxm removed the request for review from a team March 29, 2022 22:14
@marcosmarxm marcosmarxm self-assigned this Mar 31, 2022
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kattos-aws there is a small change in the spec I'll do tomorrow and then I'll publish the new connector!

@kattos-aws
Copy link
Contributor Author

Great news @marcosmarxm , thanks!

@marcosmarxm marcosmarxm temporarily deployed to more-secrets April 4, 2022 21:48 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets April 4, 2022 21:48 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets April 4, 2022 21:50 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets April 4, 2022 21:50 Inactive
@marcosmarxm marcosmarxm merged commit e3523e0 into airbytehq:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants