-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🎉 New Destination: AWS Datalake #10760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @kattos-aws can you sign the CLA and share the test output from the connector? There is a implementation in python and some files in Java, can you explain the implementation you made? |
I did sign the CLA: Here is the log for the Destination Acceptance Test suite: The connector itself is in Python, but as there were no Destination Acceptance Tests in Python, I had to write a bit of Java code to be able to run the DAT. Hope that makes sense, feel free to reach out if you need more info. Also available for a call if need be! |
@kattos-aws can you share the output from the acceptance tests? |
@marcosmarxm Sorry I realize my comment was really not clear. The logs I attached in my previous comment are actually the output of the acceptance tests. I did not implement specific integration tests. I ran the tests as indicated in the generated README.md:
If you search for the string I hope that clears that out! If not, feel free to reach out. Thanks! |
@alafanechere @marcosmarxm would either of you have bandwidth to review this PR from Stephane, our friend at AWS? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kattos-aws there is a small change in the spec I'll do tomorrow and then I'll publish the new connector!
Great news @marcosmarxm , thanks! |
What
This destination connector allows for ingestion of data into an AWS data lake.
How
This destination connector takes advantage of the new governed tables features to better integrate the data into the larger AWS data ecosystem (ex: Glue, Athena, Redshift, ...)
Recommended reading order
docs/integrations/aws-datalake.md
airbyte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/destination.py
airbyte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/airbyte_helper.py
airbyte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/aws_helpers.py
🚨 User Impact 🚨
None
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.