Skip to content

add keepalive for TCP socket in KubePodProcess #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

cgardens
Copy link
Contributor

What

@subodh and I noticed that the TCP connections to the source stay open in the case this OC issue. It is possible that the ochestrator is not properly detecting that the client on the other side has closed. Adding this keep alive would detect this.

It is not clear why this is happening only in the case of user.

https://stackoverflow.com/questions/1480236/does-a-tcp-socket-connection-have-a-keep-alive

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Feb 22, 2022
@cgardens cgardens temporarily deployed to more-secrets February 22, 2022 07:01 Inactive
@cgardens cgardens temporarily deployed to more-secrets February 22, 2022 07:01 Inactive
@subodh1810
Copy link
Contributor

I tested this on my local kube deployment and had a successful sync. Going to merge it
Screenshot 2022-02-22 at 8 31 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants