-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Upgrade webapp dependencies #10507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade webapp dependencies #10507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamakase
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I only have few questions
Ignoring connectors build. This is currently broken on all PRs and this PR does not touch any connector related code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #9754
Upgrade a bunch of used dependencies. It leaves a couple of major version updates of some dependencies unsolved, since they require more changes than I wanted to put into one PR.
"Major" upgrades included in this PR:
react-intl
(e.g. removal ofFormattedHTMLMessage
)react-scripts
-> v5typescript
-> 4.5How
See inline comments for more details where I actually changed code, and it wasn't simply a reformatting. I've also did a couple of minor updates where the code was anyway touched due to upgrade (also see inline comments).
I've tested that the pre commit hooks, building, running and running storybook are still working after this update.
Because in the newer react-script versions also eslint warnings will fail on CI, I needed to disable all eslint warnings in place here for now and we should still investigate and keep fixing them over time.