Skip to content

Upgrade webapp dependencies #10507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 22, 2022
Merged

Upgrade webapp dependencies #10507

merged 14 commits into from
Feb 22, 2022

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Feb 21, 2022

What

Part of #9754

Upgrade a bunch of used dependencies. It leaves a couple of major version updates of some dependencies unsolved, since they require more changes than I wanted to put into one PR.

"Major" upgrades included in this PR:

  • react-intl (e.g. removal of FormattedHTMLMessage)
  • react-scripts -> v5
  • typescript -> 4.5

How

See inline comments for more details where I actually changed code, and it wasn't simply a reformatting. I've also did a couple of minor updates where the code was anyway touched due to upgrade (also see inline comments).

I've tested that the pre commit hooks, building, running and running storybook are still working after this update.

Because in the newer react-script versions also eslint warnings will fail on CI, I needed to disable all eslint warnings in place here for now and we should still investigate and keep fixing them over time.

@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Feb 21, 2022
@timroes timroes temporarily deployed to more-secrets February 21, 2022 16:42 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 16:42 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 16:48 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 16:48 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 17:16 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 17:16 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 17:23 Inactive
@timroes timroes temporarily deployed to more-secrets February 21, 2022 17:23 Inactive
@timroes timroes marked this pull request as ready for review February 21, 2022 17:47
@timroes timroes requested a review from jamakase February 21, 2022 17:47
@timroes timroes changed the title Upgrade minor webapp dependencies Upgrade webapp dependencies Feb 22, 2022
@timroes timroes temporarily deployed to more-secrets February 22, 2022 08:49 Inactive
@timroes timroes temporarily deployed to more-secrets February 22, 2022 08:49 Inactive
Copy link
Contributor

@jamakase jamakase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only have few questions

@timroes timroes temporarily deployed to more-secrets February 22, 2022 10:25 Inactive
@timroes timroes temporarily deployed to more-secrets February 22, 2022 10:25 Inactive
@timroes timroes temporarily deployed to more-secrets February 22, 2022 11:30 Inactive
@timroes timroes temporarily deployed to more-secrets February 22, 2022 11:30 Inactive
@timroes
Copy link
Contributor Author

timroes commented Feb 22, 2022

Ignoring connectors build. This is currently broken on all PRs and this PR does not touch any connector related code.

@timroes timroes merged commit f66fc19 into master Feb 22, 2022
@timroes timroes deleted the tim/webapp/upgrade-dependencies branch February 22, 2022 11:56
@timroes timroes mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants