Skip to content

Fix build by updating broken tests and freezing MarkupSafe version #10468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2022

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Feb 18, 2022

What

*The conector build is broken because of a backward compatibility issue with the latest version of MarkupSafe. The root problem is in datamodel_code_generator, but freezing the version of MarkupSafe should be enough to fix the build

  • Fix tests that were broken when CI was broken

@girarda girarda temporarily deployed to more-secrets February 18, 2022 23:15 Inactive
@girarda girarda temporarily deployed to more-secrets February 18, 2022 23:15 Inactive
@girarda girarda changed the title freeze version Freeze MarkupSafe version to fix datamodel_code_generator exception in connector build Feb 18, 2022
@girarda girarda marked this pull request as ready for review February 18, 2022 23:17
@girarda
Copy link
Contributor Author

girarda commented Feb 18, 2022

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1867004138
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1867004138
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
normalization/__init__.py                                                                                                           4      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/stream_processor.py                                                                               520    333    36%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_config/transform.py                                                                                       150     36    76%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1381    521    62%

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 23:21 Inactive
@girarda girarda temporarily deployed to more-secrets February 18, 2022 23:42 Inactive
@girarda girarda temporarily deployed to more-secrets February 18, 2022 23:42 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Feb 19, 2022
@girarda girarda temporarily deployed to more-secrets February 19, 2022 00:05 Inactive
@girarda girarda temporarily deployed to more-secrets February 19, 2022 00:05 Inactive
@girarda girarda temporarily deployed to more-secrets February 19, 2022 00:32 Inactive
@girarda girarda temporarily deployed to more-secrets February 19, 2022 00:32 Inactive
@girarda girarda changed the title Freeze MarkupSafe version to fix datamodel_code_generator exception in connector build Fix build by updating broken tests and freezing MarkupSafe version Feb 19, 2022
@girarda girarda merged commit 7f6dd9b into master Feb 19, 2022
@girarda girarda deleted the alex/code-generation branch February 19, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants