Skip to content

Add back the comment #10444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add back the comment #10444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airbyte-db/lib/src/main/java/io/airbyte/db/jdbc/DefaultJdbcDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ public <T> Stream<T> query(final CheckedFunction<Connection, PreparedStatement,

@Override
public void close() throws Exception {
// Close the source in case we are using a datasource implementation that requires closing.
// BasicDataSource from apache does since it also provides a pooling mechanism to reuse connections.
if (dataSource instanceof AutoCloseable autoCloseable) {
autoCloseable.close();
}
Expand Down