Skip to content

Add banner when there is a problem with credits #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2022

Conversation

juliachvyrova
Copy link
Contributor

@juliachvyrova juliachvyrova commented Feb 17, 2022

What

Add red banner at top of page when there is a problem with credits

Снимок экрана 2022-02-18 в 16 14 38

Closes #9755

@juliachvyrova juliachvyrova self-assigned this Feb 17, 2022
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Feb 17, 2022
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some contrast ratio issue and some typing correction. Besides that looks good.

@juliachvyrova juliachvyrova temporarily deployed to more-secrets February 18, 2022 13:20 Inactive
@juliachvyrova juliachvyrova temporarily deployed to more-secrets February 18, 2022 13:20 Inactive
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, haven't tested locally.

@jamakase jamakase merged commit 9610ecb into master Feb 20, 2022
@jamakase jamakase deleted the julia/banner-for-credits-problem branch February 20, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add red banner at top of page when there is a problem with credits
4 participants