Skip to content

🐛 Source Quickbooks: update label Quickbooks -> QuickBooks #10346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Feb 15, 2022

Signed-off-by: Sergey Chvalyuk [email protected]

What

Update label Quickbooks -> QuickBooks by company request

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr requested a review from igrankova February 15, 2022 12:15
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 15, 2022
@grubberr grubberr temporarily deployed to more-secrets February 15, 2022 12:17 Inactive
@grubberr grubberr temporarily deployed to more-secrets February 15, 2022 12:17 Inactive
@igrankova igrankova linked an issue Feb 16, 2022 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets February 16, 2022 14:01 Inactive
@grubberr grubberr temporarily deployed to more-secrets February 16, 2022 14:01 Inactive
@grubberr grubberr changed the title Quickbooks -> QuickBooks 🐛 Source Quickbooks: update label Quickbooks -> QuickBooks Feb 17, 2022
@grubberr grubberr assigned grubberr and unassigned igrankova Feb 17, 2022
@grubberr grubberr temporarily deployed to more-secrets February 17, 2022 07:58 Inactive
@grubberr grubberr temporarily deployed to more-secrets February 17, 2022 07:58 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets February 17, 2022 08:03 Inactive
@grubberr grubberr temporarily deployed to more-secrets February 17, 2022 08:03 Inactive
@grubberr grubberr requested a review from annalvova05 February 17, 2022 08:04
@grubberr
Copy link
Contributor Author

grubberr commented Feb 17, 2022

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1857450240
❌ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1857450240
🐛 https://gradle.com/s/ca4ukaxggx6ry
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 11 passed, 9 errors in 22.57s ====================

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 17, 2022 08:07 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Feb 17, 2022

/test connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1859169803
✅ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1859169803
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/tests/test_incremental.py        69     38    45%
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 17, 2022 14:26 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Feb 17, 2022

/publish connector=connectors/source-quickbooks-singer

🕑 connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1859256726
✅ connectors/source-quickbooks-singer https://github.com/airbytehq/airbyte/actions/runs/1859256726

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 17, 2022 14:43 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr merged commit 3eb3367 into master Feb 17, 2022
@grubberr grubberr deleted the grubberr/quickbooks-cap-case branch February 17, 2022 14:52
@grubberr grubberr linked an issue Feb 17, 2022 that may be closed by this pull request
@grubberr grubberr temporarily deployed to more-secrets February 17, 2022 14:53 Inactive
@grubberr grubberr temporarily deployed to more-secrets February 17, 2022 14:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuickBooks source connector - Change naming
4 participants