Skip to content

🎉 End-to-end test source: support stream duplication #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Feb 12, 2022

What

  • Support stream duplication.
  • This new feature will be used in load test in cloud benchmarks.

How

  • The single stream mode is now single schema mode.
  • Its schema can be duplicated N times.
  • Also add Sentry trace for each stream.

Sentry Trace

Screen Shot 2022-02-11 at 23 56 20

🚨 User Impact 🚨

  • None expected.

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Feb 12, 2022
@tuliren tuliren requested review from edgao and subodh1810 February 12, 2022 07:04
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Feb 12, 2022
@tuliren tuliren changed the title 🎉 End-to-end test source: support schema duplication 🎉 End-to-end test source: support stream duplication Feb 12, 2022
@tuliren
Copy link
Contributor Author

tuliren commented Feb 12, 2022

/test connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1833104898
✅ connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1833104898
No Python unittests run

@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 07:23 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 07:23 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 12, 2022 07:25 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Feb 12, 2022

/test connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1833164233
✅ connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1833164233
No Python unittests run

@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 07:57 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 07:57 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 12, 2022 07:58 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Feb 12, 2022

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1833203409
✅ connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1833203409

@tuliren
Copy link
Contributor Author

tuliren commented Feb 12, 2022

/publish connector=connectors/source-e2e-test-cloud

🕑 connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/1833203728
✅ connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/1833203728


I published the wrong cloud version here. It should be 2.1.0, not 2.0.1.

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 12, 2022 08:16 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 12, 2022 08:16 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Feb 12, 2022

/publish connector=connectors/source-e2e-test-cloud

🕑 connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/1833229050
✅ connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/1833229050

@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 08:27 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 08:27 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 12, 2022 08:28 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 08:35 Inactive
@tuliren tuliren temporarily deployed to more-secrets February 12, 2022 08:35 Inactive
@tuliren tuliren merged commit 39049cb into master Feb 12, 2022
@tuliren tuliren deleted the liren/duplicated-mock-streams branch February 12, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants