Use worker config resource requirements by default in jobs #10231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
lmossman
commented
Feb 9, 2022
| @@ -113,6 +114,8 @@ public SchedulerApp(final Path workspaceRoot, | |||
| } | |||
|
|
|||
| public void start() throws IOException { | |||
| final Configs configs = new EnvConfigs(); | |||
| final WorkerConfigs workerConfigs = new WorkerConfigs(configs); | |||
There was a problem hiding this comment.
I believe this should be safe to do here in the SchedulerApp, because I see that the resource requirement env variables exist in each of these environments:
- Docker compose:
Lines 67 to 70 in 84d1456
- Kube overlays:
airbyte/kube/overlays/stable/.env
Lines 57 to 60 in 84d1456
- Helm charts:
airbyte/charts/airbyte/templates/scheduler/deployment.yaml
Lines 127 to 146 in 84d1456
lmossman
commented
Feb 9, 2022
|
|
||
| public DefaultJobCreator(final JobPersistence jobPersistence, final ConfigRepository configRepository) { | ||
| public DefaultJobCreator(final JobPersistence jobPersistence, |
There was a problem hiding this comment.
This is the class with the main changes of using the WorkerConfig resource requirements if they are not set on the StandardSync
This reverts commit 39d21f0.
jrhizor
approved these changes
Feb 9, 2022
lmossman
deleted the
lmossman/use-worker-config-resource-requirements-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that resource requirements were not actually being populated on jobs in cloud, so this PR causes the DefaultJobCreator to use the resource requirements from WorkerConfigs by default if they are not populated in the StandardSync