Skip to content

Normalization Clickhouse: Fix exception in case password is not provided #10219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Normalization Clickhouse: Fix exception in case password is not provided #10219

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a38600
Normalization Clickhouse: Fix exception in case password is not provided
CrafterKolyan Feb 9, 2022
7b6d5ab
Do not provide password in dbt config in case there is no one
CrafterKolyan Feb 10, 2022
922bcc1
Merge branch 'patch-3' of github.com:CrafterKolyan/airbyte into marco…
marcosmarxm Feb 16, 2022
040e787
bump connector version
marcosmarxm Feb 16, 2022
e29f764
bump normalization version
marcosmarxm Feb 16, 2022
dcc5253
Merge branch 'master' into marcos/test-pr-10219
marcosmarxm Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/bases/base-normalization/normalization/transform_config/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ def transform_clickhouse(config: Dict[str, Any]):
"port": config["port"],
"schema": config["database"],
"user": config["username"],
"password": config["password"],
"password": config.get("password", ""),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will assign "" an empty string as the password. Can you check if the expected config is maybe without this key or with None instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see the password field may be omitted:
https://github.com/burmecia/dbt-clickhouse/blob/cbac6c11893f8485de417b350c73095192c6ce86/dbt/include/clickhouse/sample_profiles.yml#L13-L19

}
if "tcp-port" in config:
dbt_config["port"] = config["tcp-port"]
Expand Down