Destination Snowflake Execute COPY in parallel #10212

VitaliiMaltsev · 2022-02-09T09:26:17Z

What

Currently, destination-snowflake's copy modes will generate multiple files on S3 or GCS, and then for each of those files, execute a COPY command in serial. We should run those commands in parallel to be more time-efficient.

How

COPY command can accept up to 1,000 files.

🚨 User Impact 🚨

there should not be visible user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

VitaliiMaltsev · 2022-02-16T18:42:20Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1854607052
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1854607052
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
normalization/__init__.py                                                                                                           4      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/stream_processor.py                                                                               520    333    36%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_config/transform.py                                                                                       148     34    77%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1379    519    62%

edgao

two final comments, but otherwise this lgtm!

edgao · 2022-02-17T00:19:21Z

...in/java/io/airbyte/integrations/destination/snowflake/SnowflakeParallelCopyStreamCopier.java

+import java.util.concurrent.ExecutorService;
+import java.util.stream.IntStream;
+
+interface SnowflakeParallelCopyStreamCopier {


can you add javadoc comments to the methods in this interface?

can you add javadoc comments to the methods in this interface?

done

...ke/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeGcsStreamCopier.java

VitaliiMaltsev · 2022-02-17T09:31:51Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1857825513
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1857825513
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
normalization/__init__.py                                                                                                           4      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/stream_processor.py                                                                               520    333    36%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_config/transform.py                                                                                       148     34    77%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1379    519    62%

VitaliiMaltsev · 2022-02-17T17:32:52Z

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1860132032
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1860132032

VitaliiMaltsev · 2022-02-17T17:45:33Z

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1860192267
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1860192267

…el-copy

vmaltsev added 30 commits December 15, 2021 10:45

fix for jdk 17

93d53ac

Merge branch 'master' of github.com:airbytehq/airbyte

ede8d38

Merge branch 'master' of github.com:airbytehq/airbyte

27be3fe

Merge branch 'master' of github.com:airbytehq/airbyte

ca75033

Merge branch 'master' of github.com:airbytehq/airbyte

72ab46f

Merge branch 'master' of github.com:airbytehq/airbyte

aec3384

Merge branch 'master' of github.com:airbytehq/airbyte

7efd5aa

Merge branch 'master' of github.com:airbytehq/airbyte

6a773f9

Merge branch 'master' of github.com:airbytehq/airbyte

fa18537

Merge branch 'master' of github.com:airbytehq/airbyte

b0ba37b

Merge branch 'master' of github.com:airbytehq/airbyte

fa31a0d

Merge branch 'master' of github.com:airbytehq/airbyte

67e0bd6

Merge branch 'master' of github.com:airbytehq/airbyte

ec0d1bd

Merge branch 'master' of github.com:airbytehq/airbyte

23598ec

Merge branch 'master' of github.com:airbytehq/airbyte

59d63e6

Merge branch 'master' of github.com:airbytehq/airbyte

e2cb62c

Merge branch 'master' of github.com:airbytehq/airbyte

632583a

Merge branch 'master' of github.com:airbytehq/airbyte

2bc76ce

Merge branch 'master' of github.com:airbytehq/airbyte

9baf2e1

Merge branch 'master' of github.com:airbytehq/airbyte

ed4f1ba

Merge branch 'master' of github.com:airbytehq/airbyte

64f823f

Merge branch 'master' of github.com:airbytehq/airbyte

6cea9ab

Merge branch 'master' of github.com:airbytehq/airbyte

a2cb023

Merge branch 'master' of github.com:airbytehq/airbyte

475a34c

Merge branch 'master' of github.com:airbytehq/airbyte

f75c1c1

Merge branch 'master' of github.com:airbytehq/airbyte

3078535

Merge branch 'master' of github.com:airbytehq/airbyte

cc4e646

Merge branch 'master' of github.com:airbytehq/airbyte

2b8d8c1

Merge branch 'master' of github.com:airbytehq/airbyte

9349a29

Merge branch 'master' of github.com:airbytehq/airbyte

a90eaba

VitaliiMaltsev temporarily deployed to more-secrets February 16, 2022 18:42 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 16, 2022 18:44 Inactive

edgao reviewed Feb 17, 2022

View reviewed changes

refactoring

68c8401

VitaliiMaltsev temporarily deployed to more-secrets February 17, 2022 09:05 Inactive

add javadoc

9d66d1d

VitaliiMaltsev temporarily deployed to more-secrets February 17, 2022 09:31 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 17, 2022 09:34 Inactive

VitaliiMaltsev requested a review from edgao February 17, 2022 11:22

edgao approved these changes Feb 17, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets February 17, 2022 17:35 Inactive

bump version

8c8af18

VitaliiMaltsev temporarily deployed to more-secrets February 17, 2022 17:47 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 17, 2022 17:48 Inactive

vmaltsev added 3 commits February 17, 2022 21:12

Merge branch 'master' of github.com:airbytehq/airbyte

cb67a38

Merge branch 'master' into vmaltsev/9087-destination-snowflake-parral…

1520489

…el-copy

update destination_specs.yaml

fb3d9b4

VitaliiMaltsev merged commit c9bd5e9 into master Feb 17, 2022

VitaliiMaltsev deleted the vmaltsev/9087-destination-snowflake-parralel-copy branch February 17, 2022 19:16

VitaliiMaltsev temporarily deployed to more-secrets February 17, 2022 19:17 Inactive

octavia-squidington-iii mentioned this pull request Feb 17, 2022

Bump Airbyte version from 0.35.30-alpha to 0.35.31-alpha #10446

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination Snowflake Execute COPY in parallel #10212

Destination Snowflake Execute COPY in parallel #10212

VitaliiMaltsev commented Feb 9, 2022 •

edited

Loading

VitaliiMaltsev commented Feb 16, 2022 •

edited by github-actions bot

Loading

edgao left a comment

edgao Feb 17, 2022

VitaliiMaltsev Feb 17, 2022

VitaliiMaltsev commented Feb 17, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 17, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 17, 2022 •

edited by github-actions bot

Loading

Destination Snowflake Execute COPY in parallel #10212

Destination Snowflake Execute COPY in parallel #10212

Conversation

VitaliiMaltsev commented Feb 9, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

VitaliiMaltsev commented Feb 16, 2022 • edited by github-actions bot Loading

edgao left a comment

Choose a reason for hiding this comment

edgao Feb 17, 2022

Choose a reason for hiding this comment

VitaliiMaltsev Feb 17, 2022

Choose a reason for hiding this comment

VitaliiMaltsev commented Feb 17, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 17, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 17, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 9, 2022 •

edited

Loading

VitaliiMaltsev commented Feb 16, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 17, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 17, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 17, 2022 •

edited by github-actions bot

Loading