Track const config values in analytics #10120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edgao
force-pushed
the
edgao/analytics_const_tracking
branch
from
d58a337 to
f3e8b8b
Compare
Comment on lines
231
to
232
| // Note: this doesn't handle additionalProperties, so if a config contains properties that are not | ||
| // explicitly declared in the schema, they will be ignored. |
There was a problem hiding this comment.
Would it be worth reporting the names of additionalProperties not declared in the schema instead of ignoring them?
If we studied the metadata sent to segment on those, we could have a sense of what's missing in the connector specs maybe?
There was a problem hiding this comment.
realized that I might as well just handle additionalProperties in a smarter way, can you take a look at this? e74066d#diff-8ef120819d2dd157a1e8d1838a49917772872273fefb9719b56aa303174581abL235-R261
...duler/persistence/src/main/java/io/airbyte/scheduler/persistence/job_tracker/JobTracker.java
Outdated
Show resolved
Hide resolved
ChristopheDuong
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #9618
How
JobTracker now uses the config spec to determine which values are
const, and inserts them into the event metadata appropriately.Notably:
propertiesfieldoneOfschemas are manually matched against the config. This is pretty inefficient - a deeply-nested config with manyoneOfs would match the "leaf" nodes many times. But that doesn't seem likely to actually happen.Recommended reading order
mergeMaps,flatten, and then the twoconfigToMetadatamethods. Then read the rest of the filetestConfigToMetadata; everything else is just to fix the mocked ConfigRepository objects🚨 User Impact 🚨
Nope