Closed
Description
Enviroment
- Airbyte version: is 0.22.0-alpha
- OS Version / Instance: Ubuntu 20.04
- Deployment: Docker
- Source Connector and version: Square - 0.1.0
- Destination Connector and version: Local CSV
- Severity: Medium
- Step where error happened: Source Acceptance Test
Current Behavior
Hello. Acceptance tests on square-source are failing because of an error
File "/usr/local/lib/python3.7/site-packages/airbyte_cdk/sources/streams/http/http.py", line 240, in read_records
E response = self._send_request(request, request_kwargs)
E TypeError: _send_request() takes 2 positional arguments but 3 were given
It is connected with CDK update of airbyte_cdk/sources/streams/http/http.py
file on 175 line
Before update it was
def _send_request(self, request: requests.PreparedRequest) -> requests.Response:
After update:
def _send_request(self, request: requests.PreparedRequest, request_kwargs: Mapping[str, Any]) -> requests.Response:
I am using the _send_request
method to handle errors from API in core stream class
So I need to update this method in the connector and make a new /publish release of the connector
Expected Behavior
SAT goes PASSED
Logs
Are you willing to submit a PR?
I will submit the PR with fix for this issue