Skip to content

TypingAndDedupingTests: RecordDiffer should accept airbyte metadata column names instead of hardcoding them #30112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edgao opened this issue Sep 1, 2023 · 0 comments · Fixed by #30356
Assignees
Labels
team/destinations Destinations team's backlog

Comments

@edgao
Copy link
Contributor

edgao commented Sep 1, 2023

minor tech debt from #30056

Snowflake's T+D expected records (in both sqlgenerator and TDTest) have lowercase _airbyte_extracted_at, etc. even though the columns are actually uppercased in the destination. This is because SnowflakeTestUtils now has a dumb hack to downcase those columns when dumping the final table.

Remove that hack. Update the expected records to have uppercase _AIRBYTE_* column names.

Update RecordDiffer to accept the metadata column names in the constructor, rather than hardcoding lowercased _airbyte_* everywhere. Then snowflake can pass in uppercased names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/destinations Destinations team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant