Skip to content

Source Sendgrid: date-times processed as string #19969

Closed
@attaxia

Description

@attaxia

Environment

  • Airbyte version: 0.40.18
  • OS Version / Instance: Debian
  • Deployment: Docker
  • Source Connector and version: Sendgrid 0.2.16
  • Destination Connector and version: Postgres 0.3.26
  • Step where error happened: Sync job

Current Behavior

The Sendgrid source handles date-times as Strings, which means they're saved as strings in the destination which causes issues in our BI tool later down the line. For example, the messages model has a column called last_event_time which will hold string values such as 2022-10-17T09:54:26Z.

Expected Behavior

Use the appropriate data type which should result in the correct column type in my destination.

Steps to Reproduce

  1. Run any Sendgrid integration

Are you willing to submit a PR?

I looks like it may be a simple fix by editing this file:
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-sendgrid/source_sendgrid/schemas/messages.json

And changing

    "last_event_time": {
      "type": "string"
    }

to:

    "last_event_time": {
      "type": "date-time"
    }

But I'm not sure it's that simple nor do I have the resources to test it. If it is that simple, I can of course open a PR (this applies to multiple schemas for this integration)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions