Skip to content

Destination ClickHouse: doesn't have a logo #19283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mshustov opened this issue Nov 10, 2022 · 2 comments
Closed

Destination ClickHouse: doesn't have a logo #19283

mshustov opened this issue Nov 10, 2022 · 2 comments
Labels
area/connectors Connector related issues community team/destinations Destinations team's backlog type/bug Something isn't working

Comments

@mshustov
Copy link
Contributor

  • Airbyte version: Airbyte cloud
  • OS Version / Instance: macOS
  • Deployment: Airbyte cloud
  • Destination Connector and version: 0.2.0
  • Step where error happened: Create a new ClickHouse destination

Current Behavior

The ClickHoise logo is not rendered.
2022-11-10_14-03-02

I expected #17483 to fix the problem.
@grishick Shouldn't it be updated automatically as per #16970 (review) ?
Should we add an icon here?

airbyte/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml

Lines 67 to 72 in 1b134d8

- name: Clickhouse
destinationDefinitionId: ce0d828e-1dc4-496c-b122-2da42e637e48
dockerRepository: airbyte/destination-clickhouse
dockerImageTag: 0.2.0
documentationUrl: https://docs.airbyte.com/integrations/destinations/clickhouse
releaseStage: alpha

Are you willing to submit a PR?

Yes, if someone helps me to understand what should be changed.
@mshustov mshustov added needs-triage type/bug Something isn't working labels Nov 10, 2022
@grishick grishick added team/destinations Destinations team's backlog good first issue and removed needs-triage labels Nov 10, 2022
juweins added a commit to juweins/airbyte that referenced this issue Nov 22, 2022
@juweins
ClickHouse destination doesn't have a logo airbytehq#19283
6900918
@juweins
Copy link
Contributor

juweins commented Nov 22, 2022

I figured out there was a missing icon attribute and a typo in the relevant files.
(Excuse the mess in that commits, I had to get rid of another issue which I have not yet solved)

marcosmarxm pushed a commit that referenced this issue Nov 29, 2022
@juweins
ClickHouse destination doesn't have a logo #19283 (#19715)
208f2ec
@sajarin sajarin added area/connectors Connector related issues and removed team/tse Technical Support Engineers autoteam labels Nov 30, 2022
@sajarin sajarin changed the title ClickHouse destination doesn't have a logo Destination ClickHouse: doesn't have a logo Nov 30, 2022
Merged
@mshustov
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connectors Connector related issues community team/destinations Destinations team's backlog type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@natikgadzhi @grishick @mshustov @sajarin @juweins @octavia-squidington-iv