Skip to content

fix(helm-charts): node affinity and tolerations to the job #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mnacharov
Copy link

What

Added node affinity and tolerations to the minio-create-bucket job

Without it, it's not possible to run such a job in clusters where nodeAffinity or tolerations are required to choose the node to run on.

admission webhook "validate.kyverno.affinity-check" denied the request: resource Pod/airbyte/airbyte-minio-create-bucket was blocked due to the following policies require-node-selector: check-for-nodeselector-pods: 'validation error: Pods must specify a nodeSelector. Please add a nodeSelector to your Pod specification. For pods in namespaces with a team label, use ''team: [namespace team]'' as your nodeSelector. This prevents your Pod from being scheduled on inappropriate nodes and ensures proper resource isolation. For help, see: ** or contact **. rule check-for-nodeselector-pods failed at path /spec/nodeSelector/' validate-team-node-assignment: validate-pod-team-match: 'validation error: Pod rejected: Team mismatch. Pods must be scheduled on nodes with matching team label as the namespace (team: grsi). For help, see: ** or contact **. rule validate-pod-team-match failed at path /spec/nodeSelector/'

How

Add nodeSelector and tolerations to the "create-bucket" job with the same content as minio itself has.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2025

CLA assistant check
All committers have signed the CLA.

@mnacharov mnacharov changed the title fix(helm-charts): added node affinity and tolerations to the minio-create-bucket job fix(helm-charts): added node affinity and tolerations Jun 25, 2025
@mnacharov mnacharov changed the title fix(helm-charts): added node affinity and tolerations fix(helm-charts): added node affinity and tolerations to the job Jun 25, 2025
@mnacharov mnacharov changed the title fix(helm-charts): added node affinity and tolerations to the job fix(helm-charts): duplicate node affinity and tolerations to the job Jun 25, 2025
@mnacharov mnacharov changed the title fix(helm-charts): duplicate node affinity and tolerations to the job fix(helm-charts): node affinity and tolerations to the job Jun 25, 2025
…eate-bucket job

Without it, it's not possible to run such a job in clusters where
nodeAffinity or tolerations are required to choose the node to run
@mnacharov mnacharov force-pushed the minio-nodeAffinity branch from c5b34bf to fa864c2 Compare June 25, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants