Skip to content

Commit cfdad4e

Browse files
committed
chore: fix hashing mapper test (#13913)
1 parent 671a36f commit cfdad4e

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

airbyte-mappers/src/test/kotlin/io/airbyte/mappers/transformations/HashingMapperTest.kt

+3-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import io.airbyte.config.FieldType
66
import io.airbyte.config.StreamDescriptor
77
import io.airbyte.config.adapters.TestRecordAdapter
88
import io.airbyte.mappers.transformations.HashingMapper.Companion.supportedMethods
9-
import io.mockk.every
109
import io.mockk.spyk
1110
import org.junit.jupiter.api.Assertions.assertEquals
1211
import org.junit.jupiter.api.Assertions.assertFalse
@@ -86,18 +85,17 @@ class HashingMapperTest {
8685
"test",
8786
mapOf(
8887
HashingMapper.TARGET_FIELD_CONFIG_KEY to "field1",
89-
HashingMapper.METHOD_CONFIG_KEY to HashingMapper.SHA256,
88+
HashingMapper.METHOD_CONFIG_KEY to hashingMethod,
9089
HashingMapper.FIELD_NAME_SUFFIX_CONFIG_KEY to "_hashed",
9190
),
9291
)
9392

94-
every { hashingMapper.hashAndEncodeData(HashingMapper.SHA256, "value1".toByteArray()) } returns "hashed_value"
95-
9693
val record = TestRecordAdapter(StreamDescriptor().withName("stream"), mapOf("field1" to "value1", "field2" to "value2"))
9794
hashingMapper.map(config, record)
9895

9996
assertTrue(record.has("field1_hashed"))
100-
assertEquals("hashed_value", record.get("field1_hashed").asString())
97+
val hashedValue = record.get("field1_hashed").asString()
98+
assertTrue("hashed_value" != hashedValue && hashedValue.all { it.isLetterOrDigit() }, "$hashedValue doesn't look like a valid hash")
10199
assertFalse(record.has("field1"))
102100
assertTrue(record.has("field2"))
103101
assertEquals("value2", record.get("field2").asString())

0 commit comments

Comments
 (0)