chore: official Helm mocks #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernielomax
force-pushed
the
bernielomax/chore/helm-mocks
branch
2 times, most recently
from
78863af to
d8aa1ca
Compare
|
Ah yes! I was trying to remember how this was now managed and couldn't find it. I'll fix that up. |
|
@colesnodgrass fixup added. |
colesnodgrass
approved these changes
Jul 1, 2025
Abctl creates a subset interface based on Go Helms official client interface. Just use the official interface since it can now be mocked.
* Replaced table-driven tests with direct mock setup for single-case tests to improve readability and reduce unnecessary indirection. * Used GoMock idioms (.Return, .Times, .After) for retry logic to make mock expectations clearer and more robust. * Added comments to clarify mock and test intent, aiding future maintainers. * Ensured all retry, error, and success paths are covered to match production logic and prevent regressions. * Maintained test and code coverage at the level of the main branch to ensure no loss in quality.
bernielomax
force-pushed
the
bernielomax/chore/helm-mocks
branch
from
b38dbca to
32a5eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replaces in house created Helm mocks, and replaces them with automatically generated mocks. Meaning we can remove the subset Helm Client interface and just use the Official client interface. Next I will aim to write some shared
internal/helmfunctions that can perform actions using the official Helm client interface as an argument.