[WIP] Get bazel tests working #991
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tswitzer-netflix as you making progress, i would close my PR which opened long time ago, feel free to cherry-pick changes if needed. I will close my PR: #911 for time being. Thank you Tom. |
|
if it is useful to you - we have a codemod script in our fork - that we used to re-write the tests into AnyFlatSpec https://github.com/zipline-ai/chronon/blob/main/scripts/codemod/test_replace.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This gets tests running successfully under bazel.
WIP: Currently only with --define spark_version=3.2
Why / Goal
They were not running and broken when I enabled them.
Test Plan
Checklist
Reviewers