Reuse Dedup Shuffle #937
Open
Reuse Dedup Shuffle #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-zlai
reviewed
Mar 12, 2025
Comment on lines
+139
to
+140
| plannedJoin.queryExecution.logical match { | ||
| case ExtractEquiJoinKeys(_, _, rightKeys, _, _, _, _) => |
There was a problem hiding this comment.
is planning the join necessary? couldn't tell if you just needed rightKeys , and if you just needed that, is pulling it from ExtractEquiJoinKeys via logical plan the only way?
There was a problem hiding this comment.
rightKeys is only knowable after planning the join; spark will insert additional normalization functions to ensure correctness:
The only way I've found to correctly detect and re-use the knownfloatingpointnormalized(normalizenanandzero(...)) functions is to plan a join.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Why / Goal
TODO
Test Plan