-
Notifications
You must be signed in to change notification settings - Fork 70
Bazel builds enabled along with sbt #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is massively impactful Krish! Thanks for putting this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to make this PR. Swapping over to bazel would be great for chronon!
Couple of comments / qs:
- Lets also add some notes on how devs can use build / add deps etc using bazel in the devnotes
- While we're keeping sbt & bazel around in the transitionary period, is there anything we need to call out for folks to take care of while updating deps / such?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! Excited about the project being bazel-fied!
983a914
to
7e8a4b2
Compare
7e8a4b2
to
3c6cf7c
Compare
5845212
to
475ba7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a comment about maintaining bazel/SBT consistency as other comments also mentioned.
🙏 Thanks for contributing - this is huge!
we are getting really close but the last commit seems breaking the build. Could you reproduce it with the sbt build?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change and being patient with our review process. Looking forward to phase 2.
Summary
Why / Goal
Goal is to improve the build environment(by sandboxing) and provide multiple spark versions
Test Plan
Unit testing green
quick start steps green https://chronon.ai/getting_started/Tutorial.html
Build commands
bazel build --config scala_2.12 --define spark_version=3.2 //spark/...
Checklist
Reviewers
@nikhilsimha @piyush-zlai