Use Cython 3.1 universally

[lysnikolaou]

What do these changes do?

• Use Cython 3.1 universally
• Delete unnecessary requirement files

Are there changes in behavior for the user?

No.

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes

[codspeed-hq]

CodSpeed Performance Report

Merging #1514 will degrade performances by 57.73%

_{Comparing lysnikolaou:cython-31 (4fd60e7) with master (63c4461)}

Summary

❌ 34 (👁 34) regressions
✅ 67 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
👁	test_long_query	5.9 ms	13.2 ms	-55.62%
👁	test_long_query_with_pct	17.9 ms	41.2 ms	-56.47%
👁	test_quote_long_path	4.8 ms	10.9 ms	-55.56%
👁	test_quote_query_string	314.2 µs	627.3 µs	-49.91%
👁	test_quoter_ascii	124.2 µs	204 µs	-39.12%
👁	test_quoter_pct	245.6 µs	483.3 µs	-49.18%
👁	test_quoter_quote_utf8	684.7 µs	1,619.9 µs	-57.73%
👁	test_unquoter_short	204 µs	225 µs	-9.33%
👁	test_extend_query_subclassed_str	1 ms	1.2 ms	-12.66%
👁	test_parse_query_uncached[long]	21 ms	23.4 ms	-10.23%
👁	test_parse_query_uncached[short]	1.7 ms	2 ms	-14.8%
👁	test_path_safe_uncached	230.9 µs	287.4 µs	-19.67%
👁	test_update_query_mapping	942.8 µs	1,081.7 µs	-12.84%
👁	test_update_query_mapping_with_existing_query	1.3 ms	1.5 ms	-16.09%
👁	test_update_query_sequence_mapping	4.5 ms	5.9 ms	-22.5%
👁	test_update_query_string	611.1 µs	660.5 µs	-7.48%
👁	test_url_build_access_raw_path	595.4 µs	651.4 µs	-8.6%
👁	test_url_build_no_netloc	432.2 µs	543.9 µs	-20.54%
👁	test_url_build_no_netloc_relative	419.1 µs	525.4 µs	-20.23%
👁	test_url_build_with_host_and_port	640.2 µs	702.7 µs	-8.9%
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (63c4461) to head (4fd60e7).
Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (98.07%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files          29       29              
  Lines        5798     5795       -3     
  Branches      265      265              
==========================================
- Hits         5776     5774       -2     
+ Misses         19       18       -1     
  Partials        3        3              

Flag	Coverage Δ
CI-GHA	99.63% <100.00%> (+0.01%)	⬆️
MyPy	98.07% <100.00%> (+0.01%)	⬆️
OS-Linux	99.80% <ø> (ø)
OS-Windows	99.48% <ø> (ø)
OS-macOS	99.68% <ø> (ø)
Py-3.10.11	99.45% <ø> (ø)
Py-3.10.17	99.70% <ø> (ø)
Py-3.11.12	99.70% <ø> (ø)
Py-3.11.9	99.45% <ø> (ø)
Py-3.12.10	99.70% <ø> (ø)
Py-3.13.3	99.75% <ø> (+0.04%)	⬆️
Py-3.13.4t	99.75% <ø> (ø)
Py-3.9.13	99.41% <ø> (ø)
Py-3.9.22	99.65% <ø> (ø)
Py-pypy7.3.16	99.33% <ø> (ø)
Py-pypy7.3.19	99.36% <ø> (ø)
VM-macos-latest	99.68% <ø> (ø)
VM-ubuntu-latest	99.80% <ø> (ø)
VM-windows-latest	99.48% <ø> (ø)
pytest	99.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[webknjaz]

@bdraco is this a legit coverage hit?

[Copilot]

Pull Request Overview

This PR updates the project to use Cython 3.1 universally while removing obsolete requirement files and related conditional dependency handling. Key changes include updating Cython version in requirement files and build backend, deleting test-pure and cython-freethreading requirements, and simplifying the CI/CD configuration.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
requirements/test.txt	Updated to include additional test dependencies and reference cython.txt
requirements/test-pure.txt	Removed redundant testing requirements
requirements/test-freethreading.txt	Removed obsolete freethreading testing requirements
requirements/cython.txt	Updated Cython version from 3.0.12 to 3.1.1
requirements/cython-freethreading.txt	Removed obsolete Cython freethreading requirement
pyproject.toml	Removed override configuration related to Cython freethreading
packaging/pep517_backend/_backend.py	Updated Cython dependency handling by removing the special branch for GIL-disabled builds
CHANGES/1514.packaging.rst	Documented the universal update to Cython 3.1
.github/workflows/ci-cd.yml	Simplified dependency reference for CI/CD builds

Comments suppressed due to low confidence (2)

packaging/pep517_backend/_backend.py:377

• The removal of the dedicated branch for GIL-disabled builds simplifies dependency management, but please confirm that builds relying on the prior behavior are properly handled with Cython 3.1 universally.

elif sysconfig.get_config_var('Py_GIL_DISABLED'):

.github/workflows/ci-cd.yml:262

• Changing the dependency specification from a conditional formulation to a fixed 'requirements/test.txt' may affect build configurations that previously used freethreading tests; please verify that these changes align with the intended build strategy.

requirements/test.txt

[bdraco]

Will check it when I'm back at my desk

[webknjaz]

LGTM functionally, but it'd be good to figure out the benchmark thing. I'll let @bdraco decide whether this is mergeable.

[bdraco]

At least for some of them it's now including the Cython tracing overhead and the performance regression is not real. It will take me a few hours to investigate the rest of them. I'm at the OHF summit in Dublin this week so I'm quite time limited and trying to only focus on blockers and bugs this week

[bdraco]

I will do a deep dive next week when I'm back in Texas

[bdraco]

aio-libs/frozenlist#658 seems to imply we have an issue with production wheels using line tracing

[bdraco]

#1517

Hit the same way. Let me do a PR with line tracing off and see what we get #1519

[bdraco]

Here are the benchmark results with line tracing disabled against the previous release
https://codspeed.io/aio-libs/yarl/runs/compare/680042e6d1ca3d2211b58b12..68473196e1567421a9b96153

The problem is we are benchmarking with line tracing for PRs and no line tracing for releases. We should be benchmarking what we are actually going to release. I will make a PR to fix that.

[webknjaz]

@lysnikolaou shouldn't we also use the freethreading_compatible setting, by the way?

[bdraco]

So after much investigation it turns out we are shipping wheels with linetrace on

#1521 will fix this.

[lysnikolaou]

@lysnikolaou shouldn't we also use the freethreading_compatible setting, by the way?

We're doing that already in the .pyx file itself.

[webknjaz]

@lysnikolaou shouldn't we also use the freethreading_compatible setting, by the way?

We're doing that already in the .pyx file itself.

@lysnikolaou oh, I see… I wonder if it'd be a good idea to centralize those settings through https://github.com/aio-libs/yarl/blob/3871d2c/pyproject.toml#L22-L37 so that individual pyx files wouldn't need a copy of that comment.

[lysnikolaou]

I wonder if it'd be a good idea to centralize those settings through 3871d2c/pyproject.toml#L22-L37 so that individual pyx files wouldn't need a copy of that comment.

Yeah, that's a good point. This wasn't possible up until now, because we were using different versions of Cython that did not have support for the freethreading_compatible directive, but it's now okay since we upgrade to 3.1. Opened #1528.