Run tests in debug mode in an additional CI job #1145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1145 will not alter performanceComparing Summary
|
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
changed the title
bdraco
commented
Apr 10, 2025
|
@asvetlov Looks like a segfault when running 3.9/3.10 with debug turned on as well |
webknjaz
reviewed
Apr 10, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
I think we should test everything in both debug and release modes. Consider the following snippet: |
Sorry, I don't see a failed action run. Where is the segfault? |
bdraco
added a commit
that referenced
this pull request
Apr 10, 2025
alternative to #1145 that uses the existing matrix
|
Looks like it come from
|
|
happens with |
|
failed assert multidict/multidict/_multilib/state.h Line 51 in 57c09c0 |
|
Python 3.10.17 |
|
called at multidict/multidict/_multilib/views.h Line 1172 in 57c09c0 left side is a multidict/multidict/_multilib/state.h Line 51 in 57c09c0 |
|
thanks, I'm looking |
|
I used the below to create the env to test in: |
|
I use Ubuntu, and for me bug reproducing is easier :) |
Alternate version that adjusts the matrix instead |
|
00:30 here so I'm off to bed. Feel free to adjust debug mode PRs. Will check back when I get up and moving. Cheers |
|
Fixed by #1147 |
webknjaz
reviewed
Apr 10, 2025
webknjaz
reviewed
Apr 10, 2025
Comment on lines
+428
to
+429
| - name: >- | ||
| Self-install source |
There was a problem hiding this comment.
Actually, source is never installed. Only the contents of wheels are. I think, the following will better communicate what this does.
Suggested change
| - name: >- | |
| Self-install source | |
| - name: Compile and install from source checkout |
|
|
||
| steps: | ||
| - name: Checkout project | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Could you change this to checkout from sdist instead of Git? It'll mimic what both pip and downstreams do. And this is what we really want not to crash.
There was a problem hiding this comment.
The issue was not about 'cannot build from sdist' but 'cannot build and run tests when debug mode is on'.
I don't think that the installation from sdist makes any difference here.
There was a problem hiding this comment.
Downstreams tend to additionally package debug symbols.
There was a problem hiding this comment.
What symbols? Could you please elaborate how it does related?
| path: requirements/pytest.txt | ||
| - name: >- | ||
| Self-install source | ||
| env: |
There was a problem hiding this comment.
Could you try setting PIP_CONSTRAINT? This is so the same build deps are used here and when publishing.
|
closing in favor of #1146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What This Does
🔧 New Environment Variable
The
MULTIDICT_DEBUG_BUILDenvironment variable is now available to enable a debug build.