Skip to content

Fix ref leak when calling update #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025
Merged

Fix ref leak when calling update #1135

merged 5 commits into from
Apr 9, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 9, 2025

fixes #1134
appears to be introduced in #234 (4.4.0)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 9, 2025
Copy link

codspeed-hq bot commented Apr 9, 2025

CodSpeed Performance Report

Merging #1135 will not alter performance

Comparing leak2_fix (06d3dce) with master (9850454)

Summary

✅ 244 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review April 9, 2025 04:07
@bdraco bdraco requested review from webknjaz and asvetlov as code owners April 9, 2025 04:07
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (9850454) to head (06d3dce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1135   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          27       27           
  Lines        3432     3432           
  Branches      528      528           
=======================================
  Hits         3387     3387           
  Misses         17       17           
  Partials       28       28           
Flag Coverage Δ
CI-GHA 98.68% <ø> (ø)
MyPy 83.70% <ø> (ø)
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco merged commit f7febaa into master Apr 9, 2025
79 of 81 checks passed
@bdraco bdraco deleted the leak2_fix branch April 9, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak updating CIMultiDict from mapping (present in far back as 5.2.0, likely introduced in 4.4.0) fixed in 6.4.0
2 participants