-
-
Notifications
You must be signed in to change notification settings - Fork 106
Fix memory leak on objects passed to init
, update
, or extend
#1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update
or extend
init
, update
, or extend
CodSpeed Performance ReportMerging #1121 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (83.71%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
- Coverage 91.36% 91.30% -0.07%
==========================================
Files 52 52
Lines 6349 6391 +42
Branches 627 627
==========================================
+ Hits 5801 5835 +34
- Misses 113 121 +8
Partials 435 435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Good finding. |
Please take a look at the current PR's state. |
Thanks! Thats much better and safer. 🚀 Will clean it up, add changelog, and get it shipped |
If you get a chance, aio-libs/yarl#1456 could use a followup review. |
fixes #1117