Skip to content

Fix creating CIMultiDict from MultiDict not making keys case-insentive #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 1, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 31, 2025

When MultiDict was passed to CIMultiDict the keys need to be converted
fixes #1111

side note _multidict_extend doesn't appear to use name

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Mar 31, 2025
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Performance Report

Merging #1112 will not alter performance

Comparing convert_multidict_cimultidict (00ac3fa) with master (a9d54d7)

Summary

✅ 244 untouched benchmarks

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.27%. Comparing base (41cbc0d) to head (00ac3fa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
multidict/_multidict_py.py 57.14% 0 Missing and 3 partials ⚠️

❌ Your project status has failed because the head coverage (83.58%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   91.22%   91.27%   +0.04%     
==========================================
  Files          42       42              
  Lines        6110     6176      +66     
  Branches      613      618       +5     
==========================================
+ Hits         5574     5637      +63     
  Misses        105      105              
- Partials      431      434       +3     
Flag Coverage Δ
CI-GHA 91.27% <92.10%> (+0.04%) ⬆️
MyPy 83.58% <92.10%> (+0.08%) ⬆️
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco marked this pull request as ready for review March 31, 2025 22:33
@bdraco bdraco requested a review from asvetlov as a code owner March 31, 2025 22:33
@bdraco bdraco changed the title Add regression tests for issue #1111 Fix converting MultiDict to CIMultiDict Apr 1, 2025
@bdraco
Copy link
Member Author

bdraco commented Apr 1, 2025

Feel free to adjust this PR.

I'm not sure this regression is worth yanking 6.3.0 or if this this is even a real use case ?

@bdraco bdraco removed the bot:chronographer:skip This PR does not need to include a change note label Apr 1, 2025
@bdraco bdraco requested a review from webknjaz as a code owner April 1, 2025 05:46
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 1, 2025
@bdraco bdraco changed the title Fix converting MultiDict to CIMultiDict Fix converting MultiDict to CIMultiDict not making keys case-insentive Apr 1, 2025
@bdraco bdraco changed the title Fix converting MultiDict to CIMultiDict not making keys case-insentive Fix creating CIMultiDict from MultiDict not making keys case-insentive Apr 1, 2025
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I think now the PR is good.

@bdraco bdraco merged commit 8b8e06b into master Apr 1, 2025
46 of 47 checks passed
@bdraco bdraco deleted the convert_multidict_cimultidict branch April 1, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_init_headers_MultiDict failing on PyPy
4 participants