-
-
Notifications
You must be signed in to change notification settings - Fork 106
Fix creating CIMultiDict from MultiDict not making keys case-insentive #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #1112 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (83.58%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
+ Coverage 91.22% 91.27% +0.04%
==========================================
Files 42 42
Lines 6110 6176 +66
Branches 613 618 +5
==========================================
+ Hits 5574 5637 +63
Misses 105 105
- Partials 431 434 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 3deaf72.
Feel free to adjust this PR. I'm not sure this regression is worth yanking 6.3.0 or if this this is even a real use case ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, I think now the PR is good.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
When
MultiDict
was passed toCIMultiDict
the keys need to be convertedfixes #1111
side note
_multidict_extend
doesn't appear to usename