Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for iterating multidict #1107

Merged
merged 2 commits into from
Mar 30, 2025
Merged

Add benchmarks for iterating multidict #1107

merged 2 commits into from
Mar 30, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 30, 2025

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Mar 30, 2025
Copy link

codspeed-hq bot commented Mar 30, 2025

CodSpeed Performance Report

Merging #1107 will not alter performance

Comparing benchmark_iterate (053d9c9) with master (1ba64e7)

Summary

✅ 184 untouched benchmarks
🆕 16 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_iterate_multidict[case-insensitive-c-extension-module] N/A 27.8 µs N/A
🆕 test_iterate_multidict[case-insensitive-pure-python-module] N/A 224.7 µs N/A
🆕 test_iterate_multidict[case-sensitive-c-extension-module] N/A 27.9 µs N/A
🆕 test_iterate_multidict[case-sensitive-pure-python-module] N/A 148.8 µs N/A
🆕 test_iterate_multidict_items[case-insensitive-c-extension-module] N/A 48.1 µs N/A
🆕 test_iterate_multidict_items[case-insensitive-pure-python-module] N/A 234.9 µs N/A
🆕 test_iterate_multidict_items[case-sensitive-c-extension-module] N/A 47.3 µs N/A
🆕 test_iterate_multidict_items[case-sensitive-pure-python-module] N/A 161.6 µs N/A
🆕 test_iterate_multidict_keys[case-insensitive-c-extension-module] N/A 29.2 µs N/A
🆕 test_iterate_multidict_keys[case-insensitive-pure-python-module] N/A 220.3 µs N/A
🆕 test_iterate_multidict_keys[case-sensitive-c-extension-module] N/A 29.8 µs N/A
🆕 test_iterate_multidict_keys[case-sensitive-pure-python-module] N/A 147.9 µs N/A
🆕 test_iterate_multidict_values[case-insensitive-c-extension-module] N/A 27.5 µs N/A
🆕 test_iterate_multidict_values[case-insensitive-pure-python-module] N/A 119.8 µs N/A
🆕 test_iterate_multidict_values[case-sensitive-c-extension-module] N/A 28 µs N/A
🆕 test_iterate_multidict_values[case-sensitive-pure-python-module] N/A 114.5 µs N/A

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.04%. Comparing base (1ba64e7) to head (053d9c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
+ Coverage   92.96%   93.04%   +0.07%     
==========================================
  Files          44       44              
  Lines        5190     5246      +56     
  Branches      397      401       +4     
==========================================
+ Hits         4825     4881      +56     
  Misses         95       95              
  Partials      270      270              
Flag Coverage Δ
CI-GHA 93.04% <100.00%> (+0.07%) ⬆️
MyPy 86.88% <100.00%> (+0.13%) ⬆️
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco marked this pull request as ready for review March 30, 2025 09:49
@bdraco bdraco requested a review from asvetlov as a code owner March 30, 2025 09:49
@bdraco bdraco merged commit b5d9bd1 into master Mar 30, 2025
47 checks passed
@bdraco bdraco deleted the benchmark_iterate branch March 30, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant