Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmark against all multidict implementations #1106

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Mar 28, 2025

The PR just parametrizes existing benchmarks without adding any new code.

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (389758e) to head (142098d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files          44       44           
  Lines        5188     5190    +2     
  Branches      397      397           
=======================================
+ Hits         4823     4825    +2     
  Misses         95       95           
  Partials      270      270           
Flag Coverage Δ
CI-GHA 92.96% <100.00%> (+<0.01%) ⬆️
MyPy 86.75% <100.00%> (+<0.01%) ⬆️
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Performance Report

Merging #1106 will not alter performance

Comparing benchmarks (142098d) with master (389758e)

Summary

✅ 128 untouched benchmarks
🆕 56 new benchmarks
⁉️ 14 (👁 14) dropped benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_items_view_repr 77.5 µs N/A N/A
🆕 test_items_view_repr[case-insensitive-c-extension-module] N/A 76.9 µs N/A
🆕 test_items_view_repr[case-insensitive-pure-python-module] N/A 129 µs N/A
🆕 test_items_view_repr[case-sensitive-c-extension-module] N/A 76.6 µs N/A
🆕 test_items_view_repr[case-sensitive-pure-python-module] N/A 125.5 µs N/A
👁 test_keys_view_and 96.5 µs N/A N/A
🆕 test_keys_view_and[case-insensitive-c-extension-module] N/A 100.9 µs N/A
🆕 test_keys_view_and[case-insensitive-pure-python-module] N/A 1.6 ms N/A
🆕 test_keys_view_and[case-sensitive-c-extension-module] N/A 94.1 µs N/A
🆕 test_keys_view_and[case-sensitive-pure-python-module] N/A 1.3 ms N/A
👁 test_keys_view_equals 59.6 µs N/A N/A
🆕 test_keys_view_equals[case-insensitive-c-extension-module] N/A 58.3 µs N/A
🆕 test_keys_view_equals[case-insensitive-pure-python-module] N/A 1.1 ms N/A
🆕 test_keys_view_equals[case-sensitive-c-extension-module] N/A 57.7 µs N/A
🆕 test_keys_view_equals[case-sensitive-pure-python-module] N/A 912 µs N/A
👁 test_keys_view_is_disjoint 65.6 µs N/A N/A
🆕 test_keys_view_is_disjoint[case-insensitive-c-extension-module] N/A 66.3 µs N/A
🆕 test_keys_view_is_disjoint[case-insensitive-pure-python-module] N/A 1.6 ms N/A
🆕 test_keys_view_is_disjoint[case-sensitive-c-extension-module] N/A 63.2 µs N/A
🆕 test_keys_view_is_disjoint[case-sensitive-pure-python-module] N/A 1.4 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@asvetlov asvetlov marked this pull request as ready for review March 28, 2025 20:40
@asvetlov asvetlov merged commit 1ba64e7 into master Mar 28, 2025
47 checks passed
@asvetlov asvetlov deleted the benchmarks branch March 28, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant