🧪💅 Refactor Codecov config metrics #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combined value is not very useful when one of the sources (MyPy) has no chance at reaching 100%. We may want to reconsider in the future. Instead, we'll have two separate "runtime coverage" meterics for library code and tests that will be kept at 100%, while the "type coverage" metric will remain at lower threshold. The "runtime coverage" is what we enforced, while MyPy results are advisory. When looking at Codecov, one will likely want to look at MyPy and pytest flags separately. It is usually best to avoid looking at the PR pages that sometimes display combined coverage incorrectly.
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Mar 20, 2025
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #1093 will not alter performanceComparing Summary
|
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Mar 20, 2025
webknjaz
force-pushed
the
maintenance/codecov-refactor
branch
from
c5962e4 to
92ca210
Compare
webknjaz
force-pushed
the
maintenance/codecov-refactor
branch
from
92ca210 to
c1236f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drops the project-wide Codecov metric.
The combined value is not very useful when one of the sources (MyPy)
has no chance at reaching 100%. We may want to reconsider in the
future. Instead, we'll have two separate “runtime coverage” metrics
for library code and tests that will be kept at 100%, while the
“type coverage” metric will remain at a lower threshold.
The “runtime coverage” is what we enforced, while MyPy results are
advisory.
When looking at Codecov, one will likely want to look at MyPy and
pytest flags separately. It is usually best to avoid looking at the
PR pages that sometimes display combined coverage incorrectly.
The change additionally disables the deprecated GitHub Annotations
integration in Codecov.
The default patch metric check is renamed to “runtime” to better
reflect its semantics. And another “typing” patch coverage metric
is now reported alongside it.
The badge coloring range now starts at 100%.