Skip to content

Fix a leak when the last accessed module in multidict init is not released #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2025

Conversation

asvetlov
Copy link
Member

Previously, the last accessed module (multidict._multidict_base actually) was not released and a reference to it was leaked.
It was not a big problem generally if multidict was not reloaded using Python code.
Anyway, cleaner code is better.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 16, 2025
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #1061 will not alter performance

Comparing refactor (ed68966) with master (14cf766)

Summary

✅ 38 untouched benchmarks

@asvetlov asvetlov merged commit f893493 into master Mar 16, 2025
44 of 47 checks passed
@asvetlov asvetlov deleted the refactor branch March 16, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant