-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix WebSocket reader with fragmented masked messages #10764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
related issue #10763 This is passing locally. Going to see if I can get the CI to fail
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10764 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 125 125
Lines 37798 37832 +34
Branches 2086 2090 +4
=======================================
+ Hits 37315 37349 +34
Misses 335 335
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10764 will not alter performanceComparing Summary
|
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e0cc020 on top of patchback/backports/3.11/e0cc020d59de9267146c55dbf082805213737653/pr-10764 Backporting merged PR #10764 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e0cc020 on top of patchback/backports/3.12/e0cc020d59de9267146c55dbf082805213737653/pr-10764 Backporting merged PR #10764 into master
🤖 @patchback |
(cherry picked from commit e0cc020)
(cherry picked from commit e0cc020)
Fix WebSocket reader with fragmented masked messages
We didn't have proper coverage for these cases. Add mask and large payload coverage for the reported cases since they would come through as 0 instead of the correct size.
fixes #10763
regressed in #10747