-
Notifications
You must be signed in to change notification settings - Fork 341
[feat] Add feature to delete full experiments #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This db query also deletes associated runs and notes
Hey @mauricekraus! Thanks for opening the PR. the UI side looks great! But deleting the runs from BE side is a bit more complicated process as seen here: Line 804 in 7c77d1c
I guess, there will be a need to go over the experiment runs in a loop and delete them separately. It would be great if you can make those changes. |
Sure, thanks for the heads up, i totally missed the remote part as well as the rockdb stuff. |
Handling the remote part is unnecessary in this case cause repo will be local for the UI anyways. (It's for handling the run deletions from CLI and SDK) |
@mihran113 this should resolve it, however, I'm still not sure about the remote thingy, at least locally this implementation gets rid of all runs in an experiment. |
Hey @mauricekraus! Thank a lot for the changes. This should do the job. Regarding the remote: don't worry about it, I'll add that in the future when there'll be a need.
And also would be great if you would address some code style issues here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks a lot for the contribution. I've run some tests, everything looks fine! 🎉
This pull request introduces the ability to delete entire experiments directly from the user interface.
Key Changes:
Delete Full Experiments:
Users can now delete entire experiments without having to manually select and delete individual runs.
This resolves the issue of having empty experiments after all runs are deleted, providing a more streamlined workflow.
Delete all runs of an experiment:
UI Consistency:
The delete functionality for experiments is currently available only on the experiment settings tab, making it consistent with the existing run detail deletion process.
How we should delete experiments from the dashboard needs further discussion (due to the space constraints)
Issues Resolved:
Closes #2528 , #2803