Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double pluralization of names #262

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Double pluralization of names #262

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9b2d306
prevent relationship names to be double pluralized
dkratzert Mar 22, 2023
6ca088f
Add test for double pluralized relationship
dkratzert Mar 22, 2023
2448a78
Add test for singular table name
dkratzert Mar 22, 2023
1f6f2cb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 22, 2023
d2725f2
Shorten long line
dkratzert Mar 22, 2023
5229e1b
Merge remote-tracking branch 'upstream/master' into double-pluralizat…
dkratzert Nov 29, 2024
ba86c8a
Delete test_generators.py
dkratzert Nov 29, 2024
7954f3d
Merge branch 'master' into double-pluralization-of-names
agronholm Jan 23, 2025
b45e94f
Merge branch 'master' into double-pluralization-of-names
agronholm Feb 24, 2025
bfa84f9
Merge branch 'master' into double-pluralization-of-names
agronholm Mar 8, 2025
35f11ee
Merge branch 'master' into double-pluralization-of-names
agronholm Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/sqlacodegen/generators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,9 +1076,13 @@ def generate_relationship_name(
RelationshipType.ONE_TO_MANY,
RelationshipType.MANY_TO_MANY,
):
inflected_name = self.inflect_engine.plural_noun(preferred_name)
if inflected_name:
preferred_name = inflected_name
singular_inflected_name = self.inflect_engine.singular_noun(
preferred_name
)
if singular_inflected_name:
preferred_name = self.inflect_engine.plural_noun(
singular_inflected_name
)
else:
inflected_name = self.inflect_engine.singular_noun(preferred_name)
if inflected_name:
Expand Down