Skip to content

Add customizable prefix to the uploaded gdb item's name #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Conversation

jacobdadams
Copy link
Member

load.FeatuerServiceUpdater._upload_gdb currently uploads the gdb as an item with the name "Temporary gdb upload." However, if this already exists due to not cleaning up a previous run or using this name for something else, the upload will fail and the update will bomb out. This can be a bad thing™, as sometimes existing data have already been truncated/deleted.

A parameterized prefix for this name allows the client app to set a unique name and then check for its existence prior to deleting any existing data.

Also a bunch of black/ruff updates.

@jacobdadams jacobdadams requested review from steveoh and stdavis April 1, 2024 18:25
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 93.18996% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 94.52%. Comparing base (7152210) to head (9482b2d).

Files Patch % Lines
src/palletjack/extract.py 90.19% 7 Missing and 3 partials ⚠️
src/palletjack/load.py 92.68% 5 Missing and 1 partial ⚠️
src/palletjack/transform.py 94.73% 1 Missing ⚠️
src/palletjack/utils.py 98.63% 0 Missing and 1 partial ⚠️
src/palletjack/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   93.48%   94.52%   +1.04%     
==========================================
  Files           7        7              
  Lines        1135     1133       -2     
  Branches      148      148              
==========================================
+ Hits         1061     1071      +10     
+ Misses         64       52      -12     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobdadams jacobdadams merged commit f87f4c5 into main Apr 1, 2024
5 of 7 checks passed
@jacobdadams jacobdadams deleted the dev branch April 1, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants