Skip to content

feat: Add sources metadata to statistics collection query #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion RCTAppleHealthKit/RCTAppleHealthKit+Queries.m
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ - (void)fetchCumulativeSumStatisticsCollection:(HKQuantityType *)quantityType
// Create the query
HKStatisticsCollectionQuery *query = [[HKStatisticsCollectionQuery alloc] initWithQuantityType:quantityType
quantitySamplePredicate:predicate
options:HKStatisticsOptionCumulativeSum
options:HKStatisticsOptionCumulativeSum | HKStatisticsOptionSeparateBySource
anchorDate:anchorDate
intervalComponents:interval];

Expand All @@ -961,10 +961,33 @@ - (void)fetchCumulativeSumStatisticsCollection:(HKQuantityType *)quantityType
NSString *startDateString = [RCTAppleHealthKit buildISO8601StringFromDate:startDate];
NSString *endDateString = [RCTAppleHealthKit buildISO8601StringFromDate:endDate];

NSMutableArray *metadata = [NSMutableArray arrayWithCapacity:1];

for (HKSource *source in result.sources) {

NSString *bundleIdentifier = source.bundleIdentifier;
NSString *name = source.name;
HKQuantity *sourceQuantity = [result sumQuantityForSource:source];
double quantity = [sourceQuantity doubleValueForUnit:unit];


if (quantity != 0) {
NSDictionary *sourceItem = @{
@"sourceId" : bundleIdentifier,
@"sourceName" : name,
@"quantity" : @(quantity),
};

[metadata addObject:sourceItem];
}
}


NSDictionary *elem = @{
@"value" : @(value),
@"startDate" : startDateString,
@"endDate" : endDateString,
@"metadata" : metadata,
};
[data addObject:elem];
}
Expand Down Expand Up @@ -1214,3 +1237,4 @@ - (void)fetchActivitySummary:(NSDate *)startDate
}

@end

9 changes: 8 additions & 1 deletion docs/getDailyStepCountSamples.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,14 @@ Example output, value is on count unit:
{
"endDate": "2021-03-22T17:00:00.000-0300",
"startDate": "2021-03-22T16:00:00.000-0300",
"value": 3978
"value": 3978,
"metadata": [
{
"sourceId": "com.apple.Health",
"sourceName": "Health",
"quantity": 3978
}
]
}
]
```