Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Crash when getting statistical data without permissions #280

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

GGGava
Copy link
Contributor

@GGGava GGGava commented Jan 19, 2023

Description

Lib currently crashes when trying to get statistical data without user permission. This happens because startDate and endDate fields on the query's response are null in this case, and the code crashes when trying to add them to an NSDictionary. Fixed by returning an error to js.

Fixes #97

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@GGGava GGGava requested a review from ruan-azevedo January 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes in iOS simulator if permissions are rejected.
2 participants