Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type for results of getMindfulSession #226

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

TrangPham
Copy link
Contributor

@TrangPham TrangPham commented Jun 28, 2022

Description

getMindfulSession had incorrect type set for return value. It should be Array instead of HealthValue.

docs are correct: https://github.com/agencyenterprise/react-native-health/blob/master/docs/getMindfulSession.md

code returns array:

NSMutableArray *data = [NSMutableArray arrayWithCapacity:(10)];

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@macelai macelai merged commit 1dbc199 into agencyenterprise:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants