Skip to content

F/added active member api #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

agmes4
Copy link
Member

@agmes4 agmes4 commented Jun 28, 2025

Issue

we need a way to display somewhere if a person is an active member of the AG DSN or not.

Outcome

added an API Endpoint for validating for active memberships

@agmes4 agmes4 force-pushed the f/added-active-member-api branch 2 times, most recently from 012048a to be35b0e Compare June 28, 2025 09:08
@agmes4 agmes4 force-pushed the f/added-active-member-api branch from be35b0e to 21c5a9e Compare June 28, 2025 14:18
@agmes4 agmes4 requested a review from ibot3 June 28, 2025 14:20
@agmes4 agmes4 force-pushed the f/added-active-member-api branch from 21c5a9e to ee16f0b Compare June 28, 2025 17:55
Copy link
Member

@ibot3 ibot3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but there is still that intellij runconfig template that has been deleted

Comment on lines 1 to 26
<component name="ProjectRunConfigurationManager">
<configuration default="true" type="tests" factoryName="py.test">
<module name="pycroft" />
<option name="INTERPRETER_OPTIONS" value="" />
<option name="PARENT_ENVS" value="true" />
<option name="SDK_HOME" value="" />
<option name="WORKING_DIRECTORY" value="$PROJECT_DIR$" />
<option name="IS_MODULE_SDK" value="true" />
<option name="ADD_CONTENT_ROOTS" value="true" />
<option name="ADD_SOURCE_ROOTS" value="true" />
<EXTENSION ID="PythonCoverageRunConfigurationExtension" runner="coverage.py" />
<PathMappingSettings>
<option name="pathMappings">
<list>
<mapping local-root="." remote-root="/opt/pycroft/app" />
</list>
</option>
</PathMappingSettings>
<option name="_new_keywords" value="&quot;&quot;" />
<option name="_new_parameters" value="&quot;&quot;" />
<option name="_new_additionalArguments" value="&quot;&quot;" />
<option name="_new_target" value="&quot;&quot;" />
<option name="_new_targetType" value="&quot;PYTHON&quot;" />
<method v="2" />
</configuration>
</component>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this two which but was a bit curious cause I did not add this in git. I can restore it but could discuss in any case if the .idea files are needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .idea files are definitely needed.
Please restore the file as it is the runconfig template that it used when executing single tests.

@agmes4 agmes4 force-pushed the f/added-active-member-api branch 3 times, most recently from 22a9b56 to 6e704b7 Compare June 29, 2025 10:55
Copy link
Contributor

@mabezi mabezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

For the MR in general, it might have been nice to deliver more context, what the idea or the goal is.
This might make the review easier for people who are not directly involved in the topic.

But I think this time it's okay :)

@agmes4
Copy link
Member Author

agmes4 commented Jul 1, 2025

True I already talked to Lukas thats why Lukas should know and about jakob I forget sorry

agmes4 added 3 commits July 1, 2025 14:53
added some test factories for checking if a user is an active member
added tests for the api endpoint for checking rather the is an active user or not
added api endpoint for validating if user is an active member
@agmes4 agmes4 force-pushed the f/added-active-member-api branch from 6e704b7 to 4885c71 Compare July 1, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants