-
Notifications
You must be signed in to change notification settings - Fork 9
F/added active member api #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
012048a
to
be35b0e
Compare
be35b0e
to
21c5a9e
Compare
21c5a9e
to
ee16f0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but there is still that intellij runconfig template that has been deleted
<component name="ProjectRunConfigurationManager"> | ||
<configuration default="true" type="tests" factoryName="py.test"> | ||
<module name="pycroft" /> | ||
<option name="INTERPRETER_OPTIONS" value="" /> | ||
<option name="PARENT_ENVS" value="true" /> | ||
<option name="SDK_HOME" value="" /> | ||
<option name="WORKING_DIRECTORY" value="$PROJECT_DIR$" /> | ||
<option name="IS_MODULE_SDK" value="true" /> | ||
<option name="ADD_CONTENT_ROOTS" value="true" /> | ||
<option name="ADD_SOURCE_ROOTS" value="true" /> | ||
<EXTENSION ID="PythonCoverageRunConfigurationExtension" runner="coverage.py" /> | ||
<PathMappingSettings> | ||
<option name="pathMappings"> | ||
<list> | ||
<mapping local-root="." remote-root="/opt/pycroft/app" /> | ||
</list> | ||
</option> | ||
</PathMappingSettings> | ||
<option name="_new_keywords" value="""" /> | ||
<option name="_new_parameters" value="""" /> | ||
<option name="_new_additionalArguments" value="""" /> | ||
<option name="_new_target" value="""" /> | ||
<option name="_new_targetType" value=""PYTHON"" /> | ||
<method v="2" /> | ||
</configuration> | ||
</component> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen this two which but was a bit curious cause I did not add this in git. I can restore it but could discuss in any case if the .idea files are needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .idea files are definitely needed.
Please restore the file as it is the runconfig template that it used when executing single tests.
22a9b56
to
6e704b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For the MR in general, it might have been nice to deliver more context, what the idea or the goal is.
This might make the review easier for people who are not directly involved in the topic.
But I think this time it's okay :)
True I already talked to Lukas thats why Lukas should know and about jakob I forget sorry |
added some test factories for checking if a user is an active member
added tests for the api endpoint for checking rather the is an active user or not
added api endpoint for validating if user is an active member
6e704b7
to
4885c71
Compare
Issue
we need a way to display somewhere if a person is an active member of the AG DSN or not.
Outcome
added an API Endpoint for validating for active memberships