Skip to content

Clean up: Remove Foundation/Everything and outdated stuff #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2024

Conversation

felixwellen
Copy link
Collaborator

No description provided.

@felixwellen felixwellen force-pushed the fwellen/no-to-everything branch from bbb42d3 to 9181ef8 Compare May 13, 2024 13:42
@felixwellen felixwellen marked this pull request as ready for review May 14, 2024 20:46
@felixwellen
Copy link
Collaborator Author

Discussed with anders already -> merging.

@felixwellen felixwellen merged commit 59c59c0 into master May 14, 2024
1 check passed
@ncfavier
Copy link
Member

ncfavier commented Jun 7, 2024

What's the replacement for Cubical.{Core,Foundations}.Everything? The generated files only have import, not open import.

@mortberg
Copy link
Collaborator

mortberg commented Jun 9, 2024

What's the replacement for Cubical.{Core,Foundations}.Everything? The generated files only have import, not open import.

I think the idea is just to write the imports one needs instead of relying on the Everything files

@felixwellen felixwellen deleted the fwellen/no-to-everything branch July 26, 2024 15:06
@foxyseta
Copy link

What's the replacement for Cubical.{Core,Foundations}.Everything? The generated files only have import, not open import.

I think the idea is just to write the imports one needs instead of relying on the Everything files

Shouldn't https://agda.readthedocs.io/en/latest/language/cubical.html be updated then? It is still using Everything

@foxyseta
Copy link

Or maybe not since there has been no release of cubical since this PR was merged in May.

@felixwellen
Copy link
Collaborator Author

I think we could also change how the Everything-files are generated. In principle in makes sense to me, to just import everything (or a reasonable selection). I don't like the amount of imports we have in some files. It might also make sense to have something called "Common.agda" which has open imports for all the things that are usually used from some directory. Do you see any problems with that, @mortberg ?

@mortberg
Copy link
Collaborator

mortberg commented Feb 4, 2025

I think we could also change how the Everything-files are generated. In principle in makes sense to me, to just import everything (or a reasonable selection). I don't like the amount of imports we have in some files. It might also make sense to have something called "Common.agda" which has open imports for all the things that are usually used from some directory. Do you see any problems with that, @mortberg ?

Isn't it better to have lots of imports to speed up compilation? (More things can be done in parallel with a more specific dependency tree)

@felixwellen
Copy link
Collaborator Author

I don't know, but currently nothing runs in parallel.
I would expect that it does not matter, if you the dependency is from something advanced to something basic. And this is where I would like to have less imports.

@mortberg
Copy link
Collaborator

mortberg commented Feb 4, 2025

I don't know, but currently nothing runs in parallel. I would expect that it does not matter, if you the dependency is from something advanced to something basic. And this is where I would like to have less imports.

What type of Everything/Common files would you want? I don't like for example "Algebra.Everything" because it's not very often you need all algebraic structures and it's probably good to see that the file only uses groups and rings, but "Foundations.Everything" could make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants