-
Notifications
You must be signed in to change notification settings - Fork 149
Base change, sliced adjoints #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marcinjangrzybowski is this ready for review/merging? |
yes, is ready to review, |
Sure I can review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. Otherwise looks good.
@maxsnew Thank you for review, and sory for not adressing your comments earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now with the changes!
No description provided.