Skip to content

Base change, sliced adjoints #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Conversation

marcinjangrzybowski
Copy link
Contributor

No description provided.

@felixwellen
Copy link
Collaborator

@marcinjangrzybowski is this ready for review/merging?
@maxsnew are you up for reviewing this PR?

@marcinjangrzybowski
Copy link
Contributor Author

yes, is ready to review,
@felixwellen this is prerequisite to "setoids are not LLLC" PR we talked about

@maxsnew
Copy link
Collaborator

maxsnew commented May 4, 2024

Sure I can review

Copy link
Collaborator

@maxsnew maxsnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Otherwise looks good.

@marcinjangrzybowski
Copy link
Contributor Author

@maxsnew Thank you for review, and sory for not adressing your comments earlier.
I think that I addressed all your notes now :)

Copy link
Collaborator

@maxsnew maxsnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now with the changes!

@maxsnew maxsnew merged commit fce3814 into agda:master Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants