add try/finally to ensure we exit on close error #2304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When closing the consumer during a
consume
operation the consumer may throw an exceptionwhich is neither handled not reported.
This is especially problematic when this is as a result of a
SystemExit
exception wherewe are expecting the application to shutdown. Currently, when this situation occurs, the application
ends up in an inconsistent state where the consumer may be shutdown and no longer consuming,
yet the application remains up.
As an initial patch for this, we call the
app.exit()
within atry/finally
block.In my situation, the underlying root cause was a CancelledError thrown deep within aiokafka:
aio-libs/aiokafka#647
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh