add aeraki health check #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanjunchen
force-pushed
the
add-health
branch
8 times, most recently
from
d3a4469 to
298b6ad
Compare
zhaohuabing
reviewed
Jun 9, 2023
pkg/bootstrap/options.go
Outdated
| @@ -28,7 +28,9 @@ type AerakiArgs struct { | |||
| PodName string | |||
| IstioConfigMapName string | |||
| // The listening address for HTTPS (webhooks). | |||
| HTTPSAddr string | |||
| HTTPSAddr string | |||
zhaohuabing
reviewed
Jun 9, 2023
| @@ -71,20 +85,6 @@ spec: | |||
| - name: istiod-ca-cert | |||
| mountPath: /var/run/secrets/istio | |||
| readOnly: true | |||
| resources: | |||
| {{- toYaml .Values.resources | nindent 12 }} | |||
There was a problem hiding this comment.
Because I see that it not being used.
Signed-off-by: chentanjun <[email protected]>
tanjunchen
commented
Jun 9, 2023
| initialDelaySeconds: 1 | ||
| periodSeconds: 3 | ||
| timeoutSeconds: 5 | ||
| resources: |
There was a problem hiding this comment.
Still keep the resource field now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
fixed #348
Pre-Submission Checklist: