Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add golangci linter #255

Merged
merged 14 commits into from
Jun 9, 2022
Merged

ci: add golangci linter #255

merged 14 commits into from
Jun 9, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jun 9, 2022

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

Xunzhuo added 10 commits June 9, 2022 13:16
@Xunzhuo
fix golangci lint: dupl
2876139 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: gochecknoinits
215889e 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: gocyclo
6f14cc8 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: goimports
e66e367 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: gosec
10ca229 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: govet
04d0646 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: lll
e64c147 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: nakedret
bc6e03a 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: stylecheck
0906697 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix golangci lint: whitespace
069cd70 
Signed-off-by: Xunzhuo <[email protected]>
@mergify mergify bot requested a review from zhaohuabing June 9, 2022 05:26
Xunzhuo added 3 commits June 9, 2022 13:28
@Xunzhuo
add license header
7cfc820 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix lint
1f506ec 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo
fix lint
3dc2a67 
Signed-off-by: Xunzhuo <[email protected]>
zhaohuabing
zhaohuabing approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4715b6e into aeraki-mesh:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xunzhuo @zhaohuabing