Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validation webhook #236

Merged
merged 3 commits into from
Jun 1, 2022
Merged

feat: add validation webhook #236

merged 3 commits into from
Jun 1, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jun 1, 2022 •
edited
Loading

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing June 1, 2022 09:23
@Xunzhuo
fix lint
3120e33 
Signed-off-by: Xunzhuo <[email protected]>
@Xunzhuo Xunzhuo force-pushed the validation-webhook branch from f237329 to 3120e33 Compare June 1, 2022 10:58
zhaohuabing
zhaohuabing approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ab2edfc into aeraki-mesh:master Jun 1, 2022
@Xunzhuo Xunzhuo deleted the validation-webhook branch June 1, 2022 11:49
@zhaohuabing zhaohuabing mentioned this pull request Jun 3, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xunzhuo @zhaohuabing