Consistent hash load balancing settings prioritizes dependent subsets. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
reviewed
Jun 1, 2022
There was a problem hiding this comment.
@panniyuyu This PR is great. Unfortunately, we don't have an e2e test for consistent hash to verify the PR through github actions.
Have you tested the hash policy for subset locally?
locally, i make a demo by http route and compare the envoy config dump of http route and meta-protocol. And I make some dubbo requests to test, the result is as expected. I will add some e2e tests these days |
|
LGTM |
zhaohuabing
approved these changes
Jun 2, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that consistent hash lb must set in dr.spec.trafficPolicy. I think we should align with istio. Consistent hash load balancing settings prioritizes dependent subsets.