Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ApplicationProtocol CRD to cluster scope #230

Merged
merged 6 commits into from
May 24, 2022

Conversation

Sad-polar-bear
Copy link
Contributor

Signed-off-by: Sad-polar-bear [email protected]

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing May 23, 2022 13:12
Signed-off-by: Sad-polar-bear <[email protected]>
Signed-off-by: Sad-polar-bear <[email protected]>
Signed-off-by: Sad-polar-bear <[email protected]>
Signed-off-by: Sad-polar-bear <[email protected]>
Signed-off-by: Sad-polar-bear <[email protected]>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0f15f0c into aeraki-mesh:master May 24, 2022
Sad-polar-bear added a commit to Sad-polar-bear/aeraki that referenced this pull request May 25, 2022
* change ApplicationProtocol CRD to cluster scope

Signed-off-by: Sad-polar-bear <[email protected]>

* fix script issue

Signed-off-by: Sad-polar-bear <[email protected]>

* fix e2e test

Signed-off-by: Sad-polar-bear <[email protected]>

* fix e2e test

Signed-off-by: Sad-polar-bear <[email protected]>

* fix e2e test

Signed-off-by: Sad-polar-bear <[email protected]>

* fix e2e test

Signed-off-by: Sad-polar-bear <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants