Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm chart #209

Merged
merged 5 commits into from
May 12, 2022
Merged

Update helm chart #209

merged 5 commits into from
May 12, 2022

Conversation

nevermosby
Copy link
Contributor

Signed-off-by: Wen-Quan Li [email protected]

What this PR does / Why we need it:

fix #199: update helm chart

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing May 11, 2022 09:00
@nevermosby
Copy link
Contributor Author

@zhaohuabing Any idea how to fix the yaml lint error below? Or just ignore?

======================
= Linting YAML files =
======================
./manifests/charts/aeraki/templates/tcmapiservice.yaml
  16:3      error    syntax error: expected the node content, but found '-' (syntax)

@zhaohuabing
Copy link
Member

@zhaohuabing Any idea how to fix the yaml lint error below? Or just ignore?

======================
= Linting YAML files =
======================
./manifests/charts/aeraki/templates/tcmapiservice.yaml
  16:3      error    syntax error: expected the node content, but found '-' (syntax)

You can ignore the format checking by adding a line here:

ignore: |

But please do fix the "no new line character at the end of file" error

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit cc1e2f4 into aeraki-mesh:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart is outdated
2 participants